Write test method name to the UtExecution for the Sariff needs #1237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmvpm
approved these changes
Oct 26, 2022
amandelpie
deleted the
amandelpie/write_test_name_to_execution_for_sariff_needs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the Sarif Report Generation process, it uses the unique testMethodName from UtExecution to match the report to the source code. Unfortunately, this field keeps null for many cases (if summaries are failed or not generated), but in reality, later the default test name is generated.
We decided to write this generated name to the UtExecution to reuse it during Sarif Generation Report
Fixes #1218
Type of Change